This repository has been archived by the owner on May 1, 2019. It is now read-only.
Fix: Pass repository instead of array into view helper #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
localheinz
changed the title
|
like + looks good! 👍 |
| <p> | ||
| <span class="author-label">Created:</span> | ||
| <?php echo (new DateTime($module['created_at']))->format('Y-m-d') ?><br /> | ||
| <?php echo (new DateTime($this->createdAt))->format('Y-m-d') ?><br /> |
There was a problem hiding this comment.
maybe use the dateFormat helper?
localheinz
force-pushed
the
fix/module-description
branch
from
0491800
to
f90b014
Compare
|
Removed the type-hinting! |
|
Wait, there's something wrong. |
localheinz
force-pushed
the
fix/module-description
branch
from
f90b014
to
2ef9b42
Compare
|
@localheinz mergeable now? |
Ocramius
added a commit
that referenced
this pull request
Feb 10, 2015
Fix: Pass repository instead of array into view helper
|
@localheinz done, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
ModuleDescriptionview helper so it can decide itself what it needs, rather than passing a big 'ole array to it